Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore (pkg/babe): Integrate scale into babe and transaction libraries #1661

Closed
wants to merge 249 commits into from
Closed

chore (pkg/babe): Integrate scale into babe and transaction libraries #1661

wants to merge 249 commits into from

Conversation

jimjbrettj
Copy link
Contributor

@jimjbrettj jimjbrettj commented Jun 25, 2021 •
edited
Loading

Changes

  • Integrated new scale pkg into lib/transactions
  • Integrated scale into babe
  • Refactored babe to utilize new scale features. This will be expanded upon to utilize results to hopefully clean it up more.

Tests

go test ./lib/babe -v
go test ./lib/transaction -v

Note: There are errors thrown while testing with regards to block authoring (I don't think related to me) but wanted to check. Tests were still passing but wanted to get that checked out anyways.

Issues

timwu20 added 30 commits June 18, 2021 11:36
@timwu20
scale encoding with optionality, struct tag field ordering, uint128
3af8732
@timwu20
add indices caching
65388ca
@timwu20
add mtx
d586e74
@timwu20
add variable data type interface, test to compare old vs new encoding
c1d0da1
@timwu20
fix width int decode and tests
1ddf6af
@timwu20
wip
8787be5
@timwu20
[]byte, string decoding
751f020
@timwu20
encodeBool and tests
806b871
@timwu20
refactor tests, include optionality tests
f13b8a1
@timwu20
use shared tests in decode
094b90b
@timwu20
struct decode tests, and unmarshal refactor
c510b64
@timwu20
wip
10905ea
@timwu20
decode of VariantDataType, wip tests
868b0e7
@timwu20
add optionality testing
91e030b
@timwu20
fix struct tests and optionality tests
8292794
@timwu20
test VaryingDataType
2fc8515
@timwu20
wip decode refactor, use reflect.Value as passed param
5177229
@timwu20
repurpose int and uint as compact length encoded integers, remove unn…
c854487 
…ecessary handling of []int
@timwu20
cleanup, and all tests benchmark
bbc787a
@timwu20
add README
942ea32
@timwu20
update README
62eb729
@timwu20
update readme
4c75bef
@timwu20
update readme
60a74be
@timwu20
update README
5801f19
@timwu20
update README
215cc10
@timwu20
rResult encode/decode and RegisterResult
2aae887
@timwu20
wip cr feedback
40c2728
@timwu20
add licenses
3c836b6
@timwu20
add custom primitive encode/decode
416321e
@timwu20
more cr feedback
d6ba1fc
jimjbrettj and others added 28 commits July 1, 2021 12:42
@jimjbrettj
resolve type issue
849eaf5
@jimjbrettj
fixed unknown error data populating issue
1a614b6
@jimjbrettj
WIP/Get module data to be populated when unmarshalling
097c3cf
@jimjbrettj
resolved data population issue
0bc78ef
@jimjbrettj
WIP/Finish babe error handling refactor
c333acc
@jimjbrettj
rebase with development
77387ad
@jimjbrettj
final merge changes
0c2d5e3
@jimjbrettj
added further testing for dispatch errors
0d23e32
@jimjbrettj
refactor unknown transaction errors
3d4463b
@jimjbrettj
refactor error handling
25bd7e9
@jimjbrettj
inital integration of scale pkg into babe
0b9baf7
@jimjbrettj
remove changes in scale pkg
187f255
@jimjbrettj
fix leftover comments
6968e58
@jimjbrettj
reorganize receivers
52e0a5d
@jimjbrettj
formatting
580af87
@jimjbrettj
lint and tidy
b9b1133
@jimjbrettj
use marshal to encode block body
a6358c4
@jimjbrettj
cr revisions
949aba0
@jimjbrettj
WIP/use results for unmarshalling
c7bfc64
@timwu20 @jimjbrettj
fixed it
b64ffb9
@jimjbrettj
use result type for dispatch error
e5eb888
@jimjbrettj
WIP/Finish result implementation
67cf81c
@jimjbrettj
WIP/Fix decoding custom VDT types
7385b11
@jimjbrettj
use results for unmarshalling dispatchErrors
64001ee
@jimjbrettj
cleanup
580a392
@jimjbrettj
merge
f286e15
@jimjbrettj
Merge branch 'jimmy/integrateScalePkg' of github.com:ChainSafe/gossam…
47f2050 
…er into jimmy/integrateScalePkg
@jimjbrettj
lint
f1eff85
@jimjbrettj jimjbrettj closed this Jul 1, 2021
@jimjbrettj jimjbrettj deleted the jimmy/integrateScalePkg branch July 5, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot noot approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@arijitAD arijitAD Awaiting requested review from arijitAD

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@P1sar P1sar Awaiting requested review from P1sar P1sar will be requested when the pull request is marked ready for review P1sar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jimjbrettj @CLAassistant @timwu20 @EclesioMeloJunior @noot @dutterbutter @edwardmack